FixFest at Collabora

Hacking and fixing Collabora Online

Last week we had a Fixfest at Collabora where anyone could stop any further development and solve one of those pet bugs that you would like to see it fixed but still didn’t get around to do it. Basically is a nice way to improve and polish corners :) . Here is what I was able to pick and fix:

Improve look and feel of notebookbar when on a tablet

  • when opening a document (before pressing edit button) the document name looks butchered
  • Fix menu layout when going from landscape to portrait
  • Fix centre alignment
  • Safari is setting old safari-styles and overriding ours

This actually ended up to also benefit desktop: PR#1869

Remove unnecessary duplicity when using Notebookbar mode

While fixing this also took the opportunity to fix other layout related issues:

  • Remove duplicated of “Field” (Fields dialog)
    • Retain bigtoolitem
    • Remove menutoolitem with label
  • Fix alignment of remaining field items
    • Group it in two groups
    • Vertically so to use notebookbar space more efeciently

PR#1810

Fix button sizes

  • Close https://github.com/CollaboraOnline/online/pull/1212
    • brings regressions
  • Come up with better fix
    • consistent sizes between classic and NB
    • also fix bigger hover status on those buttons

PR#1848

Draw: NotebookBar: Fix Print control and Add download as PNG

Draw was missing direct download as png. I also took the opportunity to add some more improvements:

  • Make it as bigtoolitem instead (to be consistent with the other apps)
  • Make use of command

PR#1808

There was also time to do some much needed patch porting and review/test.